Remove validation to stat call for symlinks since is a breaking change #57551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, subsequently remove the symlink cache logic as is no longer needed
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsSubsequently, remove the symlink cache logic as is no longer needed. cc @danmoseley
|
carlossanlop
approved these changes
Aug 17, 2021
jozkee
commented
Aug 17, 2021
| @@ -52,72 +52,6 @@ protected override void AssertLinkExists(FileSystemInfo link) | |||
| } | |||
| } | |||
|
|
|||
| [Theory] | |||
There was a problem hiding this comment.
These tests were validating that we throw when a self-referencing symlink is found in the recursion, while that is true for windows, that wasn't the case for Unix in 5.0, and it was going to be a breaking change caused by the same validation that I'm removing, so I updated the tests to ensure what is expected matches with 5.0
carlossanlop
approved these changes
Aug 17, 2021
|
CI issues are nuget erros and test failure is #57452. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsequently, remove the symlink cache logic as is no longer needed.
Fixes #57221
cc @danmoseley