-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw on invalid payload length in WebSockets #57598
Throw on invalid payload length in WebSockets #57598
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue Detailsnull
|
(If this doesn't make the RC1 snap, it'll need to be ported over.) |
Failures are unrelated:
|
@CarnaViire can you please create ports to branches release/6.0 and release/6.0-rc1? (we will send the 6.0-rc1 one to Tactics first) |
/backport to release/6.0-rc1 |
Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1143099091 |
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1143161019 |
Port of 9eb5680
Description:
Avoid integer overflow to prevent infinite loop in reading from WebSocket. (also complies better with WebSocket RFC)
MSRC 65273 - Prevents DoS attack by sending frames with invalid payload length.
Risk: Low
Impacted assemblies: System.Net.WebSockets.dll