Take the memory operand size for some hw intrinsic instructions

[kunalspathak]

For certain HW intrinsic instructions like insert/extract, during outputting, we should check the memory operand size rather than the data operand size to determine if the memory is correctly aligned. We already have special handling during emitDispIns() but should be done also during outputting.

I tried searching around id->idOpSize() for other places this must be happening and don't see anything except at the code path I updated. While I was there, also pass precalculated simdSize value instead of recalculating it again.

Fixes: #57458

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

---

For certain HW intrinsic instructions like insert/extract, during outputting, we should check the memory operand size rather than the data operand size to determine if the memory is correctly aligned. We already have special handling during emitDispIns() but should be done also during outputting.

I tried searching around id->idOpSize() for other places this must be happening and don't see anything except at the code path I updated. While I was there, also pass precalculated simdSize value instead of recalculating it again.

Fixes: #57458

Author:	kunalspathak
Assignees:	-
Labels:	area-CodeGen-coreclr
Milestone:	-

[kunalspathak]

Failures are related to #57620

[kunalspathak]

@dotnet/jit-contrib @tannergooding

[tannergooding]

LGTM.

I'm not sure if we've exhaustively checked instructions for places where the attr size and the memory size can differ. The display handling was best effort based on known issues, afair.

[ghost]

Hello @kunalspathak!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.