Eliminate DACCESS_COMPILE from gc.cpp and gcpriv.h #57607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsDo not merge - this is an experiment only
|
This was referenced Aug 18, 2021
cshung
force-pushed
the
experiment-only
branch
from
9a8b72e
to
5b27fcb
Compare
cshung
force-pushed
the
experiment-only
branch
from
5b27fcb
to
5537f2a
Compare
cshung
changed the title
|
Looks good to me. Perhaps we should protect against DACCESS_COMPILE being defined after all through some source code or build change though? Something like: #ifdef DACCESS_COMPILE |
I will add this in my next PR. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears to me that
DACCESS_COMPILEis never defined ongc.cppandgcpriv.h. Eliminate them from the files to simplify things.