[release/6.0-rc1] [mono] Fix crash in common_call_trampoline due to inconsistent rgctx mode #57677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…mode * Assume MRGCTX mode if mini_method_is_default_method is true * Fixes #57664
github-actions
bot
requested review from
imhameed,
lambdageek,
SamMonoRT and
vargaz
as code owners
|
Tagging subscribers to this area: Issue DetailsBackport of #57665 to release/6.0-rc1 /cc @lambdageek @uweigand Customer ImpactTestingRisk
|
jeffschwMSFT
approved these changes
Aug 19, 2021
lewing
added
Servicing-consider
|
Approved in email. |
|
@lewing can you request a cr and then we can merge. |
lewing
approved these changes
Aug 19, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #57665 to release/6.0-rc1
/cc @lambdageek @uweigand
Customer Impact
Code using generic default interface methods may crash when using the Mono (e.g. on Android or ios emulators or devices).
Testing
Manual testing.
Risk
Moderate - we can turn off generic sharing in the JIT, but not FullAOT.