Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WinMD handling in System.Reflection.MetadataLoadContext #58344

Closed
wants to merge 5 commits into from

Commits on Aug 30, 2021

  1. Fix WinMD handling in System.Reflection.MetadataLoadContext

    Add a test to prevent regressions
    andrew-boyarshin committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    d0806d6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    114f43d View commit details
    Browse the repository at this point in the history
  3. Skip the new test on Browser platform

    The MetadataLoadContext should work on Browser, but the test requires
    better MetadataAssemblyResolver implementation
    andrew-boyarshin committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    66463ea View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2021

  1. Configuration menu
    Copy the full SHA
    ccb94df View commit details
    Browse the repository at this point in the history
  2. Bring back the test skip for Browser

    System.Runtime still fails to resolve on Browser.
    WinMD parsing on Browser is questionable enough. Though, with better
    MetadataAssemblyResolver impl it should still work. Making this new
    unit test be Browser-aware is out-of-scope for this fix.
    The issue to be fixed is not related to assembly loading at all.
    andrew-boyarshin committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    7698e90 View commit details
    Browse the repository at this point in the history