Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTTP/3] Stress disable offending op causing server errors #58442

Merged
merged 1 commit into from
Aug 31, 2021
Merged

[HTTP/3] Stress disable offending op causing server errors #58442

merged 1 commit into from
Aug 31, 2021

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP commented Aug 31, 2021 •
edited
Loading

Kestrel doesn't like Expect 100 Continue in H/3.

See #58110 (comment)
Contributes to #56310
Fixes #55261

@ghost
Copy link

ghost commented Aug 31, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Kestrel doesn't like Expect 100 Continue in H/3.

See #58110 (comment)
Contributes to #56310

Author: ManickaP
Assignees: -
Labels:

area-System.Net.Http
Milestone: -

@ManickaP
Copy link
Member Author

/azp run runtime-libraries stress-http

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP ManickaP mentioned this pull request Aug 31, 2021
Closed
@ManickaP ManickaP marked this pull request as ready for review August 31, 2021 19:41
@ManickaP ManickaP mentioned this pull request Aug 31, 2021
Closed
antonfirsov
antonfirsov approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ManickaP ManickaP merged commit 5ca197c into dotnet:main Aug 31, 2021
@ManickaP ManickaP deleted the mapichov/56310_disable_100_continue branch August 31, 2021 19:55
@karelz
Copy link
Member

karelz commented Aug 31, 2021

@ManickaP this may be worth backporting to 6.0, right?

@ManickaP
Copy link
Member Author

ManickaP commented Sep 1, 2021

Yep, @antonfirsov did some PRs enabling the stress pipeline there (has it been merged?), so we should probably get this there as well.

@ManickaP
Copy link
Member Author

ManickaP commented Sep 2, 2021

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1193516392

@github-actions github-actions bot mentioned this pull request Sep 2, 2021
Merged
@karelz karelz added this to the 7.0.0 milestone Sep 2, 2021
@karelz karelz mentioned this pull request Sep 9, 2021
Closed
@adityamandaleeka
Copy link
Member

@ManickaP FYI, we are about to get 100 continue support for h3 into Kestrel in both main and 6.0

dotnet/aspnetcore#36168 (main)
dotnet/aspnetcore#36395 (release/6.0)

Thanks again for finding this!

@ManickaP
Copy link
Member Author

Awesome, thanks! I'll update the stress tests once it gets into the nightly docker image.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonfirsov antonfirsov antonfirsov approved these changes

Assignees
No one assigned
Labels
area-System.Net.Http
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

H/2 stress many failure in content posting methods
4 participants
@ManickaP @karelz @adityamandaleeka @antonfirsov