-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-target Json and Logger Source Generators between Roslyn v3.9 and v4.0 #58446
Merged
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
91b38de
Multi-target LoggerMessageGenerator between Roslyn v3.9 and v4.0
eerhardt 8111fcf
Include a .targets file in NuGet packages which will select the corre…
eerhardt c83f8ee
Multi-target JsonSourceGenerator between Roslyn v3.9 and v4.0
eerhardt b4ae25b
Fix restore
eerhardt b236905
Update NuGet package MSBuild logic to detect when SupportsRoslynCompo…
eerhardt f066e4e
Handle non-SDK projects by running after ResolveNuGetPackageAssets
eerhardt 156212f
Respond to PR feedback
eerhardt da82ee6
Merge remote-tracking branch 'upstream/main' into MultiTargetSGs
eerhardt 6f6c634
Merge remote-tracking branch 'upstream/main' into MultiTargetSGs
eerhardt fd4a6a8
Respond to latest changes
eerhardt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
<Project> | ||
<Target Name="_{TargetPrefix}GatherAnalyzers"> | ||
|
||
<ItemGroup> | ||
<_{TargetPrefix}Analyzer Include="@(Analyzer)" Condition="'%(Analyzer.NuGetPackageId)' == '{NuGetPackageId}'" /> | ||
</ItemGroup> | ||
</Target> | ||
|
||
<Target Name="_{TargetPrefix}AnalyzerMultiTargeting" | ||
Condition="'$(SupportsRoslynComponentVersioning)' != 'true'" | ||
AfterTargets="ResolvePackageDependenciesForBuild" | ||
DependsOnTargets="_{TargetPrefix}GatherAnalyzers"> | ||
|
||
<ItemGroup> | ||
<!-- Remove our analyzers targeting roslyn4.x --> | ||
<Analyzer Remove="@(_{TargetPrefix}Analyzer)" | ||
Condition="$([System.String]::Copy('%(_{TargetPrefix}Analyzer.Identity)').IndexOf('roslyn4')) >= 0"/> | ||
</ItemGroup> | ||
</Target> | ||
|
||
<Target Name="_{TargetPrefix}RemoveAnalyzers" | ||
Condition="'$({DisableSourceGeneratorPropertyName})' == 'true'" | ||
AfterTargets="ResolvePackageDependenciesForBuild" | ||
DependsOnTargets="_{TargetPrefix}GatherAnalyzers"> | ||
|
||
<!-- Remove all our analyzers --> | ||
<ItemGroup> | ||
<Analyzer Remove="@(_{TargetPrefix}Analyzer)" /> | ||
</ItemGroup> | ||
</Target> | ||
</Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now: nothing. But check out dotnet/sdk#20355 for more information.