Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a no-cache backed CLRConfig lookup mechanism #59513

Merged

Conversation

AaronRobinsonMSFT
Copy link
Member

Remove remaining locations that had a hardcoded COMPlus_ prefix.
The new no cache CLRConfig is usable from within the PAL.

Fixes #58924

/cc @BruceForstall @janvorli @hoyosjs

Remove remaining locations that had a hardcoded COMPlus_ prefix.
The new no cache CLRConfig is usable from within the PAL.
Respect the "no prefix" case for no-cache config look up.
@AaronRobinsonMSFT AaronRobinsonMSFT changed the title Add a no cache backed CLRConfig lookup mechanism Add a no-cache backed CLRConfig lookup mechanism Sep 23, 2021
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/coreclr/inc/clrconfignocache.h Outdated Show resolved Hide resolved
src/coreclr/inc/clrconfignocache.h Show resolved Hide resolved
src/coreclr/pal/src/thread/process.cpp Show resolved Hide resolved
src/coreclr/pal/src/thread/process.cpp Show resolved Hide resolved
src/coreclr/inc/clrconfigvalues.h Outdated Show resolved Hide resolved
src/coreclr/vm/autotrace.cpp Show resolved Hide resolved
@AaronRobinsonMSFT
Copy link
Member Author

Failures above are all #59541

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit b015912 into dotnet:main Sep 24, 2021
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the runtime58924_complus_dotnet branch September 24, 2021 03:41
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOTNET_ vs COMPlus_ env var prefix for creating dumps
5 participants