New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null termination for generated marshalling of read-only ref string #59726

Merged

jkoritzinsky merged 1 commit into dotnet:feature/use-dllimport-generator from elinor-fung:fixStringIn

Sep 28, 2021

Member

elinor-fung commented Sep 28, 2021 •

edited

Loading

Not sure how we managed to not hit test failures in runtimelab, but:

StringTests.UnicodeStringByRef was failing for Reverse_In because we weren't null terminating
SetError_CustomMarshallingSetsError was calling the wrong function

cc @AaronRobinsonMSFT @jkoritzinsky


          Fix null termination for generated marshalling of read-only ref string

ec76c3f

dotnet-issue-labeler bot added the area-Interop-coreclr label

jkoritzinsky approved these changes

View reviewed changes

jkoritzinsky merged commit 27d5e8d into dotnet:feature/use-dllimport-generator

elinor-fung deleted the fixStringIn branch

September 28, 2021 22:11

ghost locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Interop-coreclr