Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DllImportGenerator style to match repo conventions #59753

Merged
merged 7 commits into from
Sep 30, 2021
Merged

Update DllImportGenerator style to match repo conventions #59753

merged 7 commits into from
Sep 30, 2021

Conversation

elinor-fung
Copy link
Member

Make DllImportGenerator and Microsoft.Interop.SourceGeneration match libraries' coding conventions. Specific violations:

  • IDE0003: Remove this or Me qualification
  • IDE0018: Inline variable declaration
  • IDE0020: Use pattern matching to avoid is check followed by a cast
  • IDE0028: Use collection initializers
  • IDE0044: Add readonly modifier
  • IDE0055: Fix formatting
  • IDE1006: Naming rule violation

cc @AaronRobinsonMSFT @jkoritzinsky

@elinor-fung elinor-fung merged commit 853297a into dotnet:feature/use-dllimport-generator Sep 30, 2021
@elinor-fung elinor-fung deleted the updateStyle branch September 30, 2021 23:21
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees
No one assigned
Labels
area-System.Runtime.InteropServices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elinor-fung @jkoritzinsky @AaronRobinsonMSFT