Add back the nethost archive. #59847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This archive makes it a bit easier for developers to pull down nethost in a non-.NET environment (without NuGet). We had this in 3.1, but it was lost at some point between then and now with all of the large infrastructure changes.
|
I think this is .NET 6 worthy. It would be good to have a solid argument though. I think source-build is enough but make sure that is known. |
hoyosjs
reviewed
Oct 1, 2021
Co-authored-by: Juan Hoyos <19413848+hoyosjs@users.noreply.github.com>
elinor-fung
reviewed
Oct 1, 2021
Co-authored-by: Elinor Fung <elfung@microsoft.com>
jkoritzinsky
commented
Oct 1, 2021
|
Would be nice to have this for 6.0. But since this is fully backward compatible, people can use 7.0 builds just as well. |
jkoritzinsky
commented
Oct 3, 2021
|
All CI failures are due to #59908. This PR is ready for another round of review |
ViktorHofer
reviewed
Oct 5, 2021
ViktorHofer
reviewed
Oct 5, 2021
ViktorHofer
reviewed
Oct 5, 2021
ViktorHofer
reviewed
Oct 5, 2021
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
ViktorHofer
approved these changes
Oct 5, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This archive makes it a bit easier for developers to pull down nethost in a non-.NET environment (without NuGet). We had this in 3.1, but it was lost at some point between then and now with all of the large infrastructure changes.
With #59842, fixes #49026
cc: @vitek-karas @AaronRobinsonMSFT @elinor-fung should we backport this to 6.0 (aka do we feel that shipping the nethost archive in 6.0 is important enough to backport)