Fix a macro usage and cleanup stale comment #59907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
cc @janvorli, @jkoritzinsky, @hoyosjs, noticed these while working on dotnet/diagnostics#2638.. |
|
MSBuild task failure in SourceBuild leg is unrelated to the PR changes: #59908. |
jkoritzinsky
approved these changes
Oct 3, 2021
hoyosjs
approved these changes
Oct 3, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fcd862e, the OS and arch definitions were consolidated. 57bfe47 brought back a usage of
PLATFORM_UNIXwhich is not defined in runtime repo anymore.PR replaces it with
TARGET_UNIXand also cleans up a stale comment aboutCMAKE_USER_MAKE_RULES_OVERRIDE(which is obsolete since f1890a7).