Show dialog when running .NET 6 GUI single-file on 5.0 hostfxr #59929

vitek-karas · 2021-10-04T12:00:43Z

Should fix #59819

ghost · 2021-10-04T12:00:51Z

Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Should fix #59819

Author:	vitek-karas
Assignees:	vitek-karas
Labels:	`area-Single-File`
Milestone:	-

src/native/corehost/apphost/apphost.windows.cpp

VSadov

LGTM Thanks!!

vitek-karas · 2021-10-04T18:48:34Z

The innerloop failure is #59908

elinor-fung · 2021-10-04T18:50:56Z

src/native/corehost/apphost/apphost.windows.cpp

+            pal::string_t line;
+            pal::stringstream_t ss(g_buffered_errors);
+            while (std::getline(ss, line, _X('\n'))) {
+                if (starts_with(line, _X("Bundle header version compatibility check failed."), true))


It is not specific to this particular issue of the GUI not showing anything (and I know we still need to use / check for this string here to handle older versions), but would it be useful to also add more details to the actual error message about the header version - for if/when we have a new bundler version and someone runs against 6.0 hostfxr? My understanding is that for non-GUI, we would just end up with:

Failure processing application bundle. Bundle header version compatibility check failed.

Maybe something like the major and minor version of the header versus what is valid would at least provide a better hint as to what is wrong?

Good point - we should fix this for 7.0.

But maybe I'll add it to this change (since it affects 7.0 if cooperating with 6.0) 😢

Yeah, I think it would be nice to do for 6.0 - especially since 6.0 is LTS :(

elinor-fung · 2021-10-04T18:58:49Z

src/native/corehost/apphost/apphost.windows.cpp

+                if (starts_with(line, _X("Bundle header version compatibility check failed."), true))
+                {
+                    dialogMsg = pal::string_t(_X("To run this application, you must install .NET Desktop Runtime ")) + _STRINGIFY(COMMON_HOST_PKG_VER) + _X(" (") + get_arch() + _X(").\n\n");
+                    url = get_download_url();


Also include apphost_version=<COMMON_HOST_PKG_VER> in the URL query?

Oh my - good point!

elinor-fung · 2021-10-04T19:05:52Z

src/native/corehost/test/mockhostfxr/mockhostfxr.cpp

+
+    const pal::string_t dotnet_folder = get_directory(dotnet_root);
+
+    if (pal::strcmp(dotnet_folder.c_str(), _X("mockhostfxrBundleVersionFailure")))


nit: this one uses mockhostfxr as the prefix for the known folder name and the above uses hostfxr - can we stick with one or the other?

It should be mockhostfxr ideally

elinor-fung · 2021-10-04T19:37:55Z

src/installer/tests/Microsoft.NET.HostModel.Tests/AppHost.Bundle.Tests/BundledAppWithSubDirs.cs

+                Directory.CreateDirectory(dotnetWithMockHostFxr);
+                string expectedErrorCode = Constants.ErrorCode.BundleExtractionFailure.ToString("x");
+
+                var dotnetBuilder = new DotNetBuilder(dotnetWithMockHostFxr, sharedTestState.RepoDirectories.BuiltDotnet, "hostfxrFrameworkMissingFailure")


Shouldn't the name be mockhostfxrBundleVersionFailure? Or am I not understanding how these tests are supposed to be set up?

elinor-fung · 2021-10-04T19:48:48Z

src/native/corehost/test/mockhostfxr/mockhostfxr.cpp

+
+    const pal::string_t dotnet_folder = get_directory(dotnet_root);
+
+    if (pal::strcmp(dotnet_folder.c_str(), _X("mockhostfxrBundleVersionFailure")))


It looks like the intent is that the condition should have == 0. Same for hostfxrFrameworkMissingFailure above.

:-( - this shows exactly how long I've been away from C++ 😢

vitek-karas · 2021-10-04T21:02:24Z

We should wait for #59967 before porting to 6.0. We need the apphost_version in the URL.

Co-authored-by: Elinor Fung <elfung@microsoft.com>

vitek-karas · 2021-10-05T18:00:40Z

Backport to 6.0 should take both this and #59967 together.

agocke · 2021-10-05T18:02:24Z

/backport to release/6.0

github-actions · 2021-10-05T18:02:37Z

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1308764993

github-actions · 2021-10-05T18:04:03Z

@agocke an error occurred while backporting to release/6.0, please check the run log for details!

Error: @agocke is not a repo collaborator, backporting is not allowed.

github-actions · 2021-10-05T18:45:22Z

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1308764993

github-actions · 2021-10-05T18:47:04Z

@agocke an error occurred while backporting to release/6.0, please check the run log for details!

Error: @agocke is not a repo collaborator, backporting is not allowed.

agocke · 2021-10-05T18:48:08Z

@terrajobst I believe something is busted w/ my GitHub permissions ☹️

…t#59929) Show dialog when running .NET 6 GUI single-file on 5.0 hostfxr (cherry picked from commit 2f76c08)

Co-authored-by: Elinor Fung <elfung@microsoft.com> (cherry picked from commit 3d171f9)

…ssing (#60045) * Show dialog when running .NET 6 GUI single-file on 5.0 hostfxr (#59929) Show dialog when running .NET 6 GUI single-file on 5.0 hostfxr (cherry picked from commit 2f76c08) * Fixes based on feedback for the original #59929 (#59967) Co-authored-by: Elinor Fung <elfung@microsoft.com> (cherry picked from commit 3d171f9) Co-authored-by: Vitek Karas <vitek.karas@microsoft.com>

Show dialog when running .NET 6 GUI single-file on 5.0 hostfxr

a708015

vitek-karas requested review from mateoatr, VSadov and elinor-fung October 4, 2021 12:00

vitek-karas self-assigned this Oct 4, 2021

dotnet-issue-labeler bot added the area-Single-File label Oct 4, 2021

Disable the test on non-Windows

eca9d24

VSadov reviewed Oct 4, 2021

View reviewed changes

src/native/corehost/apphost/apphost.windows.cpp Show resolved Hide resolved

VSadov approved these changes Oct 4, 2021

View reviewed changes

vitek-karas merged commit 2f76c08 into dotnet:main Oct 4, 2021

vitek-karas deleted the DownleveBundleExtract branch October 4, 2021 19:10

elinor-fung reviewed Oct 4, 2021

View reviewed changes

vitek-karas added a commit that referenced this pull request Oct 5, 2021

Fixes based on feedback for the original #59929 (#59967)

3d171f9

Co-authored-by: Elinor Fung <elfung@microsoft.com>

agocke pushed a commit to agocke/runtime that referenced this pull request Oct 6, 2021

Show dialog when running .NET 6 GUI single-file on 5.0 hostfxr (dotne…

2a7478a

…t#59929) Show dialog when running .NET 6 GUI single-file on 5.0 hostfxr (cherry picked from commit 2f76c08)

agocke pushed a commit to agocke/runtime that referenced this pull request Oct 6, 2021

Fixes based on feedback for the original dotnet#59929 (dotnet#59967)

3ffe5ea

Co-authored-by: Elinor Fung <elfung@microsoft.com> (cherry picked from commit 3d171f9)

ghost locked as resolved and limited conversation to collaborators Nov 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show dialog when running .NET 6 GUI single-file on 5.0 hostfxr #59929

Show dialog when running .NET 6 GUI single-file on 5.0 hostfxr #59929

vitek-karas commented Oct 4, 2021

ghost commented Oct 4, 2021

VSadov left a comment

vitek-karas commented Oct 4, 2021

elinor-fung Oct 4, 2021

vitek-karas Oct 4, 2021

vitek-karas Oct 4, 2021

elinor-fung Oct 4, 2021

elinor-fung Oct 4, 2021

vitek-karas Oct 4, 2021

elinor-fung Oct 4, 2021

vitek-karas Oct 4, 2021

elinor-fung Oct 4, 2021

elinor-fung Oct 4, 2021

vitek-karas Oct 4, 2021

vitek-karas commented Oct 4, 2021

vitek-karas commented Oct 5, 2021

agocke commented Oct 5, 2021

github-actions bot commented Oct 5, 2021

github-actions bot commented Oct 5, 2021

github-actions bot commented Oct 5, 2021

github-actions bot commented Oct 5, 2021

agocke commented Oct 5, 2021


		const pal::string_t dotnet_folder = get_directory(dotnet_root);

		if (pal::strcmp(dotnet_folder.c_str(), _X("mockhostfxrBundleVersionFailure")))

Show dialog when running .NET 6 GUI single-file on 5.0 hostfxr #59929

Show dialog when running .NET 6 GUI single-file on 5.0 hostfxr #59929

Conversation

vitek-karas commented Oct 4, 2021

ghost commented Oct 4, 2021

VSadov left a comment

Choose a reason for hiding this comment

vitek-karas commented Oct 4, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vitek-karas commented Oct 4, 2021

vitek-karas commented Oct 5, 2021

agocke commented Oct 5, 2021

github-actions bot commented Oct 5, 2021

github-actions bot commented Oct 5, 2021

github-actions bot commented Oct 5, 2021

github-actions bot commented Oct 5, 2021

agocke commented Oct 5, 2021