Pin compiler version to workaround package validation loading missmatching roslyn versions #60026
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ching roslyn versions
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
All configurations is green. Merging to unblock CI and official build. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mitigates: #59908
There was a breaking change in between these 2 versions where an abstract and an interface member were added and unfortunately there is a race condition (I haven't found where), that sometimes
Microsoft.CodeAnalysisis loaded from the SDK before we call the package validation task, and then in the package validation task we loadMicrosoft.CodeAnalysis.CSharpfrom the compiler package, which depends on these new members defined onMicrosoft.CodeAnalysisbut since we are loading it from the SDK for some reason, those members are not found and hence the crash.Pinning the compiler version to unblock CI while I make more progress on the investigation