Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileSystemEntry.Unix: ensure properties are available when file is deleted. #60214

Merged
merged 12 commits into from
Nov 18, 2021
Merged

FileSystemEntry.Unix: ensure properties are available when file is deleted. #60214

merged 12 commits into from
Nov 18, 2021

Commits on Oct 9, 2021

  1. FileSystemEntry.Unix: ensure attributes are available when file is de… 

    …leted.

When the file no longer exists, we create attributes based on what we know.

The test for this was passing because it cached the attributes before the
item was deleted due to enumerating with skipping FileAttributes.Hidden.
    @tmds
    tmds committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    47183e9 View commit details
    Browse the repository at this point in the history

  2. GetLength: fix reading from uninitialized cache.

    @tmds
    tmds committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    8a0edcd View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. Update test

    @tmds
    tmds committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    ed16197 View commit details
    Browse the repository at this point in the history

  2. Add a comment to GetLength about the value it returns for symlinks.

    @tmds
    tmds committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    794f2b2 View commit details
    Browse the repository at this point in the history

  3. Always assert entry.Length on Unix

    @tmds
    tmds committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    5322a6b View commit details
    Browse the repository at this point in the history

  4. Minor refactoringcd

    @tmds
    tmds committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    2031b64 View commit details
    Browse the repository at this point in the history

  5. Add message to each assert.

    @tmds
    tmds committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    4e6f8fc View commit details
    Browse the repository at this point in the history

  6. test: update expected values for Browser platform

    @tmds
    tmds committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    4fd4f6b View commit details
    Browse the repository at this point in the history

  7. Reorder test asserts and add some comments.

    @tmds
    tmds committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    27ef95c View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2021

  1. Fix indentation.

    @tmds
    tmds authored Oct 12, 2021
    Configuration menu
    Copy the full SHA
    c1fe08f View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Also use symbolic links in the test

    @tmds
    tmds committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    4cd2e99 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. PR feedback

    @tmds
    tmds committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    3a7356e View commit details
    Browse the repository at this point in the history