Reflection Invoke share more coreclr/mono #60270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronRobinsonMSFT
added
the
NO-MERGE
|
Tagging subscribers to this area: @buyaa-n Issue DetailsWork to reuse error handling between coreclr/mono for Reflection.Invoke scenarios.
|
jkotas
reviewed
Oct 12, 2021
src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems
Outdated
Show resolved
Hide resolved
AaronRobinsonMSFT
requested review from
BrzVlad,
lambdageek,
marek-safar,
naricc,
thaystg and
vargaz
as code owners
|
/cc @lambdageek @vargaz |
BrzVlad
reviewed
Oct 12, 2021
marek-safar
reviewed
Oct 12, 2021
src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs
Outdated
Show resolved
Hide resolved
lambdageek
reviewed
Oct 12, 2021
lambdageek
reviewed
Oct 12, 2021
lambdageek
reviewed
Oct 13, 2021
src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs
Outdated
Show resolved
Hide resolved
AaronRobinsonMSFT
removed
the
NO-MERGE
steveharter
reviewed
Oct 13, 2021
src/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs
Show resolved
Hide resolved
…hare # Conflicts: # src/mono/mono/metadata/icall.c # src/mono/mono/metadata/object.c
|
@steveharter and @buyaa-n Any further thoughts on this change? |
elinor-fung
reviewed
Oct 14, 2021
src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs
Outdated
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
lambdageek
reviewed
Apr 5, 2022
Comment on lines
-4896
to
-4907
| if (has_byref_nullables) { | ||
| /* | ||
| * The runtime invoke wrapper already converted byref nullables back, | ||
| * and stored them in pa, we just need to copy them back to the | ||
| * managed array. | ||
| */ | ||
| for (i = 0; i < mono_array_length_internal (params); i++) { | ||
| MonoType *t = sig->params [i]; | ||
|
|
||
| if (m_type_is_byref (t) && t->type == MONO_TYPE_GENERICINST && mono_class_is_nullable (mono_class_from_mono_type_internal (t))) | ||
| mono_array_setref_internal (params, i, pa [i]); | ||
| } |
There was a problem hiding this comment.
@AaronRobinsonMSFT oops, I think this caused #67269
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work to reuse error handling between coreclr/mono for Reflection.Invoke scenarios.
Fixes mono/mono#14962
Fixes mono/mono#14993
Fixes mono/mono#14998
/cc @jkoritzinsky @elinor-fung