Experiment with Roslyn optimization for ROS<T> in assembly data section #60327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
gfoidl
reviewed
Oct 13, 2021
src/libraries/Common/src/System/Net/Http/aspnetcore/Http2/Hpack/Huffman.cs
Show resolved
Hide resolved
davidwrighton
approved these changes
Oct 16, 2021
There was a problem hiding this comment.
Looks good to me... If you get a chance, the Roslyn and Runtime branches now have the optimized pattern implemented, and it would be lovely to see if we can see improvements or not. Also, I'd love to see this checked in to the hackathon branch if everything still works well.
Rolls it out to most static readonly T[] fields initialized to only const values. This will tank perf until Roslyn optimizes these.
stephentoub
force-pushed
the
hackspanblit
branch
from
c2f0161 to
c8dc2b2
Compare
|
Nice thing about an API these get lowered to is it's easy to find all the places it's being used: |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolls it out to most static readonly T[] fields initialized to only const values. This will tank perf until Roslyn optimizes these.
@jaredpar, you were asking about where we'd use this in dotnet/runtime.