SortedList<TKey, TValue> added GetKeyAtIndex, GetValueAtIndex, and SetValueAtIndex #60520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-collections Issue DetailsImplemented set value at index method.
|
|
Apologies for not looking at this PR, seems like it was missed by the labelling bot. Will get back to you ASAP. |
| // Sets the value of the entry at the given index. | ||
| public void SetValueAtIndex(int index, TValue value) | ||
| { | ||
| if (index< 0 || index >= _size) |
There was a problem hiding this comment.
Nit: indentation
Suggested change
| if (index< 0 || index >= _size) | |
| if (index < 0 || index >= _size) |
| SortedList<TKey, TValue> dictionary = (SortedList<TKey, TValue>)GenericIDictionaryFactory(count); | ||
| Assert.All(Enumerable.Range(0, count), index => | ||
| { | ||
| Assert.Equal(index, dictionary.IndexOfValue(dictionary.GetValueAtIndex(index))); |
There was a problem hiding this comment.
I assume this would require unique values, but if the test is passing then I guess it's fine.
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented set value at index method.
Exposed get at index methods.
per approved API Proposal #58962