Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmark runs for superpmi collection to use net7.0 #60671

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

kunalspathak
Copy link
Member

Until now, we were building microbenchmarks needed to do superpmi collection with net6.0. Switch to use net7.0.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 20, 2021
@ghost
Copy link

ghost commented Oct 20, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Until now, we were building microbenchmarks needed to do superpmi collection with net6.0. Switch to use net7.0.

Author: kunalspathak
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@kunalspathak
Copy link
Member Author

@dotnet/jit-contrib @BruceForstall

@kunalspathak kunalspathak merged commit c15c7cf into dotnet:main Oct 20, 2021
@BruceForstall
Copy link
Member

This is going to change and get broken every release, which is annoying.

@kunalspathak
Copy link
Member Author

I think there was a change sometime back that made this change to net7.0 but I think that too broke the pipeline because Microbenchmarks was not prepared for building with net7.0. See #59130

@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants