Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lock protect nullability cache of symbolic regex node #60942

Merged
merged 5 commits into from
Nov 3, 2021
Merged

lock protect nullability cache of symbolic regex node #60942

merged 5 commits into from
Nov 3, 2021

Commits on Nov 3, 2021

  1. fixed nullability checking to be threadsafe

    @veanes
    veanes committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    8824109 View commit details
    Browse the repository at this point in the history

  2. use volatile write for nullability cache 

    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    @veanes @stephentoub
    veanes and stephentoub committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    a825077 View commit details
    Browse the repository at this point in the history

  3. made read of nullability cache volatile and fixed other PR comments

    @veanes
    veanes committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    d5cb37c View commit details
    Browse the repository at this point in the history

  4. made non-lock-protected reads from SymbolicRegexBuilder._delta volatile

    @veanes
    veanes committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    a5ca169 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review

    @stephentoub @veanes
    stephentoub authored and veanes committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    970a4a8 View commit details
    Browse the repository at this point in the history