Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions for using Codespaces #60996

Merged
merged 4 commits into from
Nov 9, 2021
Merged

Add instructions for using Codespaces #60996

merged 4 commits into from
Nov 9, 2021

Conversation

eerhardt
Copy link
Member

Also updating our onCreateCommand script to store the current commit id. Developers can use this file to know which version was built during the prebuild.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Oct 29, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Also updating our onCreateCommand script to store the current commit id. Developers can use this file to know which version was built during the prebuild.

Author: eerhardt
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@ghost
Copy link

ghost commented Oct 29, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Also updating our onCreateCommand script to store the current commit id. Developers can use this file to know which version was built during the prebuild.

Author: eerhardt
Assignees: -
Labels:

area-Infrastructure
Milestone: -

danmoseley
danmoseley approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to run a script on first use? That could not only fix HEAD but also set up remotes properly to their fork (prompting for github ID if necessary)

safern
safern approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one comment and adding the command to reset to the pre build commit on creation of the codespace, looks good. Thanks!

docs/workflow/Codespaces.md Show resolved Hide resolved
@runfoapp runfoapp bot mentioned this pull request Oct 29, 2021
Closed
@eerhardt
Copy link
Member Author

eerhardt commented Nov 9, 2021

CI failure is #61331. Merging.

@eerhardt eerhardt merged commit 3dfdcb9 into dotnet:main Nov 9, 2021
@eerhardt eerhardt deleted the AddCodespacesDoc branch November 9, 2021 02:18
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 30, 2021
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@am11 am11 am11 left review comments

@fanyang-mono fanyang-mono fanyang-mono approved these changes

@safern safern safern approved these changes

@danmoseley danmoseley danmoseley approved these changes

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eerhardt @stephentoub @am11 @danmoseley @safern @fanyang-mono