Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed the unified System.Security.Cryptography.dll #61025

Merged
merged 6 commits into from
Nov 2, 2021

Conversation

bartonjs
Copy link
Member

@bartonjs bartonjs commented Oct 29, 2021

  • All of System.Security.Cryptography.Primitives has been moved
  • AsymmericKeyExchangeFormatter moved from S.S.C.Algorithms
  • Most of the references to S.S.C.Primitives were adjusted by a script, too many moles to whack by hand.

Contributes to #55690.

* All of System.Security.Cryptography.Primitives has been moved
* AsymmericKeyExchangeFormatter moved from S.S.C.Algorithms
* Most of the references to S.S.C.Primitives were adjusted by a script, too many moles to whack by hand.
@bartonjs bartonjs added this to the 7.0.0 milestone Oct 29, 2021
@bartonjs bartonjs self-assigned this Oct 29, 2021
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Oct 29, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details
  • All of System.Security.Cryptography.Primitives has been moved
  • AsymmericKeyExchangeFormatter moved from S.S.C.Algorithms
  • Most of the references to S.S.C.Primitives were adjusted by a script, too many moles to whack by hand.
Author: bartonjs
Assignees: bartonjs
Labels:

area-System.Security

Milestone: 7.0.0

@ericstj ericstj requested a review from safern November 1, 2021 16:14
@bartonjs
Copy link
Member Author

bartonjs commented Nov 1, 2021

The "allConfigurations" build finally succeeded, so this should be in a usefully reviewable state now.

@vcsjones
Copy link
Member

vcsjones commented Nov 1, 2021

@bartonjs first, awesome. Glad this is happening. Do you have an idea on how much, if any, and when, you might continue to do the consolidation of the S.S.Cryptography libraries? I'll need to re-shuffle a number of my in-flight branches (not complaining) and would prefer to hold off on that until you think the consolidation is mostly complete.

@bartonjs
Copy link
Member Author

bartonjs commented Nov 1, 2021

how much

All of

  • System.Security.Cryptography.Primitives
  • System.Security.Cryptography.Encoding
  • System.Security.Cryptography.Algorithms
  • System.Security.Cryptography.Cng
  • System.Security.Cryptography.Csp
  • System.Security.Cryptography.OpenSsl
  • System.Security.Cryptography.X509Certificates

when

Once this goes through, it'll probably be library-by-library. Encodings, then Algorithms, then probably all the platformmy ones at once, then X509. If things get tricky then maybe split across more PRs. ("If swimmingly, then fewer"... but I don't see that happening)

The idea is to go quickly so that things like "what'd we change in net7" are easier to answer 😄.

@bartonjs bartonjs deleted the seed_unified_crypto branch November 2, 2021 16:17
@bartonjs bartonjs removed their assignment Nov 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants