Credential fixes #61114
Merged
Credential fixes #61114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue Detailsnull
|
wfurt
approved these changes
Nov 2, 2021
stephentoub
approved these changes
Nov 3, 2021
aik-jahoda
pushed a commit
to aik-jahoda/runtime
that referenced
this pull request
Nov 9, 2021
aik-jahoda
pushed a commit
to aik-jahoda/runtime
that referenced
this pull request
Nov 9, 2021
* fix HttpClientHandlerTest.RemoteServer.cs * fix HttpClientHandlerTest.Authentication.cs * fix HttpClientHandlerTest.cs
danmoseley
reviewed
Nov 9, 2021
| @@ -421,7 +421,7 @@ public async Task PostAsync_ManyDifferentRequestHeaders_SentCorrectly() | |||
| request.Headers.Add("Access-Control-Request-Method", "GET"); | |||
| request.Headers.Add("Access-Control-Request-Headers", "GET"); | |||
| request.Headers.Add("Age", "12"); | |||
| request.Headers.Authorization = new AuthenticationHeaderValue("Basic", "QWxhZGRpbjpvcGVuIHNlc2FtZQ=="); | |||
| request.Headers.Authorization = new AuthenticationHeaderValue("Basic", authSafeValue); | |||
There was a problem hiding this comment.
just curious, how did extracting this into a variable help credscan?
danmoseley
reviewed
Nov 9, 2021
| @@ -203,7 +203,7 @@ public static IEnumerable<object[]> Authentication_TestData() | |||
| { | |||
| yield return new object[] { "Basic realm=\"testrealm\"", true }; | |||
| yield return new object[] { "Basic ", true }; | |||
| yield return new object[] { "Basic realm=withoutquotes", true }; | |||
| yield return new object[] { "Basic realm=PLACEHOLDERwithoutquotes", true }; | |||
There was a problem hiding this comment.
credscan picked up on the "realm" part here? but not on line 204? It is strange...
Anipik
pushed a commit
that referenced
this pull request
Nov 9, 2021
Anipik
pushed a commit
that referenced
this pull request
Nov 10, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.