-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fold S.S.C.Encoding into new System.Security.Cryptography library #61137
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue Details
|
/azp list |
@steveisok is there a way for me to trigger WASM tests from the PR (or locally)? I'm guessing this (and the next several) code move(s) will turn on more tests that are expected to fail. Seems a bit nicer if I can see them to turn them off early. |
We reactivated the full wasm interp leg on PR's, so you should get some indication. |
...aries/System.Security.Cryptography.Encoding/src/System.Security.Cryptography.Encoding.csproj
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/src/System.Security.Cryptography.csproj
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/tests/System.Security.Cryptography.Tests.csproj
Outdated
Show resolved
Hide resolved
Sure looks like it. Good thing Santi had feedback causing me to respin :) |
Contributes to #55690.