Fix Assertion failed 'ins == INS_add' for madd/msub #61171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsFixes #61037 (comment) - it didn't expect INS_adds there (GT_ADD can set flags). Also, I decided to rewrite it to use a separate GT_MADD op (see #61045 (comment)) cc @jakobbotsch
|
jakobbotsch
reviewed
Nov 3, 2021
src/tests/JIT/Regression/JitBlue/Runtime_61037/Runtime_61037.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
|
Failures are unrelated (fail in other PRs as well) |
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61037 (comment) - it didn't expect INS_adds there (GT_ADD can set flags). Also, I decided to rewrite it to use a separate GT_MADD op (see #61045 (comment))
cc @jakobbotsch