Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BestFitMapping, CallingConvention, and ThrowOnUnmappableChar from GeneratedDllImportAttribute #61182

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Nov 3, 2021

Also removed a few cases where #if DLLIMPORTGENERATOR_ENABLED is not needed.

Contributes to #61181

cc @AaronRobinsonMSFT @jkoritzinsky

@AaronRobinsonMSFT
Copy link
Member

@elinor-fung Do we want to provide guidance in the compat doc about how to set calling conventions via the UnmanagedCallConvAttribute?

@elinor-fung
Copy link
Member Author

Jeremy already did before:

[`CallingConvention`](https://docs.microsoft.com/dotnet/api/system.runtime.interopservices.dllimportattribute.callingconvention) will not be supported for `GeneratedDllImportAttribute`. Users will be required to use the new `UnmanagedCallConvAttribute` attribute instead. This attribute provides support for extensible calling conventions and provides parity with the `UnmanagedCallersOnlyAttribute` attribute and C# function pointer syntax. We will enable our conversion code-fix to automatically convert explicit and known calling convention usage to use the `UnmanagedCallConvAttribute`.

Or do you want something more?

@AaronRobinsonMSFT
Copy link
Member

Or do you want something more?

@elinor-fung Nope. All good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants