Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to OleDb assembly and last Cryptography DllImport to GeneratedDllImport #61184

Merged

Conversation

AaronRobinsonMSFT
Copy link
Member

@ghost
Copy link

ghost commented Nov 3, 2021

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

/cc @jkoritzinsky @elinor-fung

Author: AaronRobinsonMSFT
Assignees: -
Labels:

area-System.Data.OleDB

Milestone: 7.0.0

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, can you update the OleDb P/Invokes to match the interop guidelines for the repo? (putting them in the Interop/Windows folder, etc?)

  which can cause a failure vs "missing support" which enables us to
  fallback to the marshalling forwarder.
@AaronRobinsonMSFT
Copy link
Member Author

While you're here, can you update the OleDb P/Invokes to match the interop guidelines for the repo? (putting them in the Interop/Windows folder, etc?)

I don't think I can do that in this review to be honest. The signatures don't all match and uses of those types aren't the same in all places. This would mean I'd need to update many other projects. I'm not sure how we should be doing this since the model in place now means we need to trace through all projects and permit generation which makes many of these changes very hard to reason about.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants