fix unexpected TimeSeriesLimitReached after HistogramLimitReached(#60752) #61199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti Issue DetailsThe problem is from which
|
tarekgh
reviewed
Nov 4, 2021
...ies/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/AggregationManager.cs
Show resolved
Hide resolved
noahfalk
approved these changes
Nov 5, 2021
|
Are we missing tests that should have flagged this? |
|
I am merging this as the CI is green. @itn3000 thanks for the fix. Could you please try to add a test for the case we are fixing here? |
|
Thank you for merging, I will try to create another PR for tests. |
tarekgh
pushed a commit
that referenced
this pull request
Nov 11, 2021
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is from which
_currentTimeSeriesis always added even if_currentHistogramsreachesMaxHistograms.