-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make JitPrintInlinedMethods less verbose #61208
Conversation
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsWas: Now: We can also introduce a verbosity level e.g. to only print successful inlinees after [guarded] devirtualizations. The goal is to allow developers to easily find out which call-sites were devirtualized with PGO and which were not. cc @dotnet/jit-contrib @AndyAyersMS
|
I'm not a fan of removing the ordinal and IL offset, I've been using those a lot in my debug info work. Can we keep those? |
I can make the "verbose mode" to be default. If make Checked jits available for external developers I'd love it to be more friendly and less verbose for them at least with an additional config switch. Especially when ="*" mode is used. |
Do we expect external developers to use the full JitDump mode? If we had a separate variable to report the things that may be interesting for external devs then we could have the less verbose output for this mode, and keep the more verbose mode for JitDump. |
It's not part of JitDump, it's printed for |
The inline tree is also printed in JitDump using this code. |
Maybe pass |
@jakobbotsch good point! addressed in the latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would personally prefer that "leaf" methods like these do not change behavior based on environment variables, e.g. using a verbose
parameter instead (similar to what is already happening in InlineStrategy::Dump
with its showBudget
parameter). But that's not terribly important, if you prefer it this way that's fine with me.
Was:
Now:
We can also introduce a verbosity level e.g. to only print successful inlinees after [guarded] devirtualizations. The goal is to allow developers to easily find out which call-sites were devirtualized (and inlined because devirtualization without inlining is not interesting) with PGO and which were not.
cc @dotnet/jit-contrib @AndyAyersMS