Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly mark tests with CLRTestKind=SharedLibrary #61235

Merged
merged 3 commits into from
Nov 11, 2021
Merged

Explicitly mark tests with CLRTestKind=SharedLibrary #61235

merged 3 commits into from
Nov 11, 2021

Commits on Nov 10, 2021

  1. Explicitly mark tests with CLRTestKind=SharedLibrary 

    Previously the Directory.Build.targets script used to automatically
infer that OutputType=Library without a CLRTestKind implies
SharedLibrary. This is however hard to consolidate with the planned
test merging - as the SDK script set OutputType=Library by default,
we need the combination Library+(implicit)BuildAndRun to indicate
the "new-style" [Fact]-based tests. For this reason I propose to
remove this automatic inference and manually fix the handful of tests
that are missing an explicit CLRTestKind=SharedLibrary property.
In light of this description we can theoretically remove the
OutputType=Library specification from all test projects but even if
we decide to do that, I believe it will be easier to do that as a
separate mechanical change, not as part of this relatively small
change that has a different purpose. Additionally in the one case
of the GitHub_22583 regression test, I removed the explicit setting
of GenerateRunScript=false because that's the default.

Thanks

Tomas
    @trylek
    trylek committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    44a96a2 View commit details
    Browse the repository at this point in the history

  2. Fix tests previously missed due to case-sensitive comparison of the '… 

    …Library' output type
    @trylek
    trylek committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    c52a6a1 View commit details
    Browse the repository at this point in the history

  3. Fix OutputType=exe in OpenDelegate.csproj 

    I believe this was a pre-existing bug - previously, with the
special clause regarding SharedLibrary, the test just got silently
skipped because it was considered to be a shared library.

Thanks

Tomas
    @trylek
    trylek committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    aac6425 View commit details
    Browse the repository at this point in the history