Fix the WASM Iterator test #61242
Merged
Fix the WASM Iterator test #61242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kg
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBecause this test wasn't passing a step value to JavaScript, it only ever stepped the iterator for one iteration and then continued. This meant that the test rarely actually exercised the bug it was trying to detect. By fixing it so that it runs for multiple iterations as intended, it reliably reproduces variations on the bug (it came back in one of my development branches) at the exact same point every run after a reasonably short number of steps. This PR also improves the error output and does additional checks.
|
pavelsavara
approved these changes
Nov 5, 2021
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this test wasn't passing a step value to JavaScript, it only ever stepped the iterator for one iteration and then continued. This meant that the test rarely actually exercised the bug it was trying to detect.
By fixing it so that it runs for multiple iterations as intended, it reliably reproduces variations on the bug (it came back in one of my development branches) at the exact same point every run after a reasonably short number of steps.
This PR also improves the error output and does additional checks.