Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][aot] Disable (again) Microsoft.Extensions.Logging.Generators.Roslyn3.11.Tests failing due to OOM #61323

Merged
merged 2 commits into from
Nov 9, 2021
Merged

[wasm][aot] Disable (again) Microsoft.Extensions.Logging.Generators.Roslyn3.11.Tests failing due to OOM #61323

merged 2 commits into from
Nov 9, 2021

Conversation

krwq
Copy link
Member

@krwq krwq commented Nov 8, 2021

@krwq krwq requested review from radical and lewing November 8, 2021 17:44
@ghost
Copy link

ghost commented Nov 8, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

The tests have been OOMing on almost every rolling build since this was merged.

Example rolling builds:
https://dev.azure.com/dnceng/public/_build/results?buildId=1457592&view=results
https://dev.azure.com/dnceng/public/_build/results?buildId=1457989&view=results
https://dev.azure.com/dnceng/public/_build/results?buildId=1454720&view=results

Author: krwq
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@lewing
Copy link
Member

lewing commented Nov 8, 2021

cc @marek-safar @steveisok

@krwq
Copy link
Member Author

krwq commented Nov 8, 2021 •
edited
Loading

please feel free to scope this PR (or replace) as needed, I'm taking action solely based on this failing almost consistently

@steveisok steveisok self-requested a review November 8, 2021 22:28
@radical
Copy link
Member

radical commented Nov 9, 2021

I'll push a change to restrict this to disabling the failing tests.

@radical radical changed the title Revert "[wasm] Re-enable source generator tests failing due to OOM (#60701) [wasm][aot] Disable (again) Microsoft.Extensions.Logging.Generators.Roslyn3.11.Tests failing due to OOM Nov 9, 2021
@radical radical added the arch-wasm WebAssembly architecture label Nov 9, 2021
@ghost
Copy link

ghost commented Nov 9, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

The tests have been OOMing on almost every rolling build since this was merged.

Example rolling builds:
https://dev.azure.com/dnceng/public/_build/results?buildId=1457592&view=results
https://dev.azure.com/dnceng/public/_build/results?buildId=1457989&view=results
https://dev.azure.com/dnceng/public/_build/results?buildId=1454720&view=results

Author: krwq
Assignees: -
Labels:

arch-wasm, area-Infrastructure-libraries
Milestone: -

@krwq krwq mentioned this pull request Nov 9, 2021
Closed
@krwq
Copy link
Member Author

krwq commented Nov 9, 2021

Thanks @radical. I'll merge this, the failing test looks unrelated (I've filed #61359 to track this)

@krwq krwq merged commit 2924d19 into dotnet:main Nov 9, 2021
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveisok steveisok steveisok approved these changes

@radical radical Awaiting requested review from radical

@lewing lewing Awaiting requested review from lewing

@marek-safar marek-safar Awaiting requested review from marek-safar

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krwq @lewing @radical @steveisok