Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Add task marshaling tests. #61324

Merged
merged 3 commits into from
Nov 10, 2021
Merged

Conversation

maraf
Copy link
Member

@maraf maraf commented Nov 8, 2021

Add various tests for marshaling task to JavaScript promise.

  • Sync and async.
  • Generic and non-generic.
  • Successful and failed.

These tests replace those added in the #47640.

@pavelsavara @kg Do you have some ideas for additional scenarios to test?

Add various tests for marshaling task to JavaScript promise.

- Sync and async.
- Generic and non-generic.
- Successful and failed.
@ghost
Copy link

ghost commented Nov 8, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Add various tests for marshaling task to JavaScript promise.

  • Sync and async.
  • Generic and non-generic.
  • Successful and failed.

@pavelsavara @kg Do you have some ideas for additional scenarios to test?

Author: maraf
Assignees: -
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone: 7.0.0

@kg
Copy link
Member

kg commented Nov 8, 2021

Looks good. I'd add a test for ValueTask and a test for ValueTask<int> - I believe they'll fail at present but it's worth documenting that through tests that assert they fail, since we might get requests to implement it later on.

@maraf maraf marked this pull request as ready for review November 9, 2021 09:59
@maraf
Copy link
Member Author

maraf commented Nov 10, 2021

I have added the same bunch of tests for ValueTasks as for Tasks, as I'm expecting the marshaling implementation will be different. Let me know if it's ok or we don't need all of them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants