-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Add task marshaling tests. #61324
Conversation
Add various tests for marshaling task to JavaScript promise. - Sync and async. - Generic and non-generic. - Successful and failed.
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsAdd various tests for marshaling task to JavaScript promise.
@pavelsavara @kg Do you have some ideas for additional scenarios to test?
|
Looks good. I'd add a test for |
...e.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/MarshalTests.cs
Outdated
Show resolved
Hide resolved
…ons as if the feature is implemented.
6101d42
to
5f30ce3
Compare
I have added the same bunch of tests for ValueTasks as for Tasks, as I'm expecting the marshaling implementation will be different. Let me know if it's ok or we don't need all of them. |
Add various tests for marshaling task to JavaScript promise.
These tests replace those added in the #47640.
@pavelsavara @kg Do you have some ideas for additional scenarios to test?