-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Fix incorrect CCW decoding in GetObjectForCCW #61341
Conversation
* Fix incorrect CCW decoding in GetObjectForCCW * Fix linux/mac build
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #61193 to release/6.0 /cc @davmason @mikem8361 @hoyosjs Customer ImpactThis issue blocks debugger API's for correctly identifying .NET 5.0+ COM wrappers. TestingValidated an end-to-end scenario using COM wrappers RiskLow. We are falling back to the old COM decoding logic if the new COM wrapper API code check does not succeed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Let's consider this for 6.0.x
Backport of #61193 to release/6.0
/cc @davmason @mikem8361 @hoyosjs
Customer Impact
This issue blocks debugger API's for correctly identifying .NET 5.0+ COM wrappers.
Testing
Validated an end-to-end scenario using COM wrappers
Risk
Low. We are falling back to the old COM decoding logic if the new COM wrapper API code check does not succeed.