Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SupportedOSPlatformAttribute("windows") from LdapSessionOption #61388

Merged
merged 5 commits into from
Nov 24, 2021
Merged

Remove SupportedOSPlatformAttribute("windows") from LdapSessionOption #61388

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd38ff6
Remove SupportedOSPlatformAttribute("windows") from LdapSessionOption…
macsux Nov 10, 2021
e70a338
Add explicit support for Linux on SSL in LdapSessionOptions. This cha…
macsux Nov 10, 2021
216c08b
Add SupportedOSPlatformAttribute for LdapSessionOptions.SecureSocketL…
macsux Nov 10, 2021
8fdf24b
Remove SupportedOSPlatformAttribute from LdapSessionOptions.SecureSoc…
macsux Nov 10, 2021
d4961ff
Re-adding extra line
joperezr Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/System.DirectoryServices.Protocols/ref/System.DirectoryServices.Protocols.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,7 @@ internal LdapSessionOptions() { }
public string SaslMethod { get { throw null; } set { } }
public bool Sealing { get { throw null; } set { } }
[System.Runtime.Versioning.SupportedOSPlatformAttribute("windows")]
buyaa-n marked this conversation as resolved.
Show resolved Hide resolved
[System.Runtime.Versioning.SupportedOSPlatformAttribute("linux")]
public bool SecureSocketLayer { get { throw null; } set { } }
public object SecurityContext { get { throw null; } }
public System.TimeSpan SendTimeout { get { throw null; } set { } }
Expand Down
2 changes: 2 additions & 0 deletions ...ervices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapSessionOptions.Linux.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ private static void PALCertFreeCRLContext(IntPtr certPtr) { /* No op */ }

private bool _secureSocketLayer;

[System.Runtime.Versioning.SupportedOSPlatformAttribute("windows")]
joperezr marked this conversation as resolved.
Show resolved Hide resolved
[System.Runtime.Versioning.SupportedOSPlatformAttribute("linux")]
public bool SecureSocketLayer
{
get
Expand Down
2 changes: 2 additions & 0 deletions ...vices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapSessionOptions.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ public partial class LdapSessionOptions
{
private static void PALCertFreeCRLContext(IntPtr certPtr) => Interop.Ldap.CertFreeCRLContext(certPtr);

[System.Runtime.Versioning.SupportedOSPlatformAttribute("windows")]
[System.Runtime.Versioning.SupportedOSPlatformAttribute("linux")]
public bool SecureSocketLayer
{
get
Expand Down