Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some more precise debug info improvements #61419

Merged
merged 3 commits into from
Nov 11, 2021
Merged

Some more precise debug info improvements #61419

merged 3 commits into from
Nov 11, 2021

Commits on Nov 10, 2021

  1. Some more precise debug info improvements 

    * We were not recording precise info in inlinees except for at IL offset
  0 because most of the logic that handles determining when to attach
  debug info did not run for inlinees. There are no changes in what the
  EE sees since we were normalizing debug info back to the root anyway.

* Propagate debug info even further than just until rationalization, to
  make it simpler to dump the precise debug info. This means we create
  some more GT_IL_OFFSET nodes, in particular when the inlinee debug
  info is valid but the root info is invalid. This is currently
  happening for newobj IL instructions when the constructor is inlined.
  We generate two statements:
  GT_ASG(GT_LCL_VAR(X), ALLOCOBJ(CLS));
  GT_CALL(CTOR, GT_LCL_VAR(X))
  and the first statement ends up "consuming" the debug info, meaning we
  end up with no debug info for the GT_CALL, which eventually propagates
  into the inline tree. I have held off on fixing this for now since it
  causes debug info diffs in the data reported back to the EE.

  The additional nodes in LIR result in 0.15% more memory use and 0.015%
  more instructions retired for SPMI over libraries.

There is also a small fix in gtlist.h for GT_BFIZ when
MEASURE_NODE_SIZES is defined.

No SPMI diffs.
    @jakobbotsch
    jakobbotsch committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    64db0c9 View commit details
    Browse the repository at this point in the history

  2. Run jit-format

    @jakobbotsch
    jakobbotsch committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    ea04c11 View commit details
    Browse the repository at this point in the history

  3. Add a space before dumping debug info in LIR

    @jakobbotsch
    jakobbotsch committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    3e53210 View commit details
    Browse the repository at this point in the history