Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the "TargetingPack" folder in the mobile apps. #61432

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented Nov 10, 2021

Include the "TargetingPack" folder in the mobile app test suites.

Fixes #61322
Fixes #61299

@ghost
Copy link

ghost commented Nov 10, 2021

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #61322
Fixes #61299

Author: jkoritzinsky
Assignees: -
Labels:

area-AssemblyLoader-mono

Milestone: -

@ghost
Copy link

ghost commented Nov 10, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Include the "TargetingPack" folder in the mobile app test suites.

Fixes #61322
Fixes #61299

Author: jkoritzinsky
Assignees: -
Labels:

area-AssemblyLoader-mono, area-Infrastructure-mono

Milestone: -

@fanyang-mono
Copy link
Member

I was wondering if you tried to run the failing test locally to validate this change? Because the CI lane for runtime tests running on mobile targets have been moved to rolling build only.

@jkoritzinsky
Copy link
Member Author

I’ll queue a rolling build directly on this branch to validate it after lunch.

@fanyang-mono
Copy link
Member

I’ll queue a rolling build directly on this branch to validate it after lunch.

Sounds good. Thank you!

@jkoritzinsky
Copy link
Member Author

Queued the CI run as a build against the branch directly, so it'll run the mobile legs too: https://dev.azure.com/dnceng/public/_build/results?buildId=1463787&view=results

@jkoritzinsky
Copy link
Member Author

Looks like the test passed in CI (The failures are on other platforms or in the libraries test tree for unrelated infrastructure issues)

@jkoritzinsky
Copy link
Member Author

@fanyang-mono @agocke can I get a review on this PR? None of the test failures are related to the fix (some of it looks like Helix infra bugs in the Python scripts TBH as the logs say the tests all passed).

@jkoritzinsky
Copy link
Member Author

As merging is blocked since the tvOSSimulator job timed out without reporting that it failed, I'm going to rerun the failed legs to try to get a mergeable PR state.

Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkoritzinsky jkoritzinsky merged commit 6f5de0b into main Nov 11, 2021
@jkoritzinsky jkoritzinsky deleted the include-external-in-mobile-apps branch November 11, 2021 08:48
@fanyang-mono
Copy link
Member

LGTM

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants