-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include the "TargetingPack" folder in the mobile apps. #61432
Conversation
Tagging subscribers to this area: |
Tagging subscribers to this area: @directhex |
I was wondering if you tried to run the failing test locally to validate this change? Because the CI lane for runtime tests running on mobile targets have been moved to rolling build only. |
I’ll queue a rolling build directly on this branch to validate it after lunch. |
Sounds good. Thank you! |
Queued the CI run as a build against the branch directly, so it'll run the mobile legs too: https://dev.azure.com/dnceng/public/_build/results?buildId=1463787&view=results |
Looks like the test passed in CI (The failures are on other platforms or in the libraries test tree for unrelated infrastructure issues) |
@fanyang-mono @agocke can I get a review on this PR? None of the test failures are related to the fix (some of it looks like Helix infra bugs in the Python scripts TBH as the logs say the tests all passed). |
As merging is blocked since the tvOSSimulator job timed out without reporting that it failed, I'm going to rerun the failed legs to try to get a mergeable PR state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
Include the "TargetingPack" folder in the mobile app test suites.
Fixes #61322
Fixes #61299