Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Proxy-Support check to be case insensitive #61446

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Update Proxy-Support check to be case insensitive #61446

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e65d63b
Update Proxy-Support check to be case insensitive
ChrisFWood Nov 11, 2021
e4d20f5
Merge branch 'dotnet:main' into issue-61414
ChrisFWood Nov 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ies/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.NtAuth.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ private static bool ProxySupportsConnectionAuth(HttpResponseMessage response)

foreach (string v in values)
{
if (v == "Session-Based-Authentication")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separately, @geoffkizer, we might want to audit use of Headers and update appropriate sites to use NonValidated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the goal here to improve performance by avoiding the added processing/memory use that happens when you go through TryGetValues etc?

There are semantic differences with NonValidated. In particular if the server sent something like

Proxy-Support: Session-Based-Authentication, Some-Other-Magic-Token

Then the current code would enumerate this as two header values and successfully match the first. In general for header processing, this is what you want (e.g. consider Connection: close handling).

If we just use NonValidated here then we would need to parse these tokens ourselves. Which we could certainly do, and we could certainly do it in a more efficient way than the current header parsing logic does (e.g. deal with spans instead of allocating strings). But I'm not sure the perf here matters much.

There could be (and almost certainly are) scenarios where this perf does matter, e.g. Connection: close. But again, it's not as simple as just using NonValidated.

In short: Yes, there are things we should look into as far as improving header access perf, but NonValidated by itself doesn't really help all that much, and we need to investigate further to determine if/how to actually do better here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the goal here to improve performance by avoiding the added processing/memory use that happens when you go through TryGetValues etc?

Yes, that would be the goal.

if (v.Equals("Session-Based-Authentication", StringComparison.OrdinalIgnoreCase))
{
return true;
}
Expand Down