[wasm] Add AppStart task to the bench Sample #61481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Measure browser app start times, 2 measurements implemented.
First to measure till the JS window.pageshow event, second to measure
time when we reach managed C# code.
Example ouput:
| measurement | time |
|-:|-:|
| AppStart, Page show | 108.1400ms |
| AppStart, Reach managed | 240.2174ms |
|
Tagging subscribers to this area: Issue DetailsMeasure browser app start times, 2 measurements implemented. First to measure till the JS window.pageshow event, second to measure Example ouput:
|
pavelsavara
approved these changes
Nov 11, 2021
| @@ -79,7 +89,10 @@ public Result RunBatch(BenchTask task, int milliseconds) | |||
| start = DateTime.Now; | |||
| for (i = 0; i < steps; i++) | |||
| { | |||
| RunStep(); | |||
| if (HasRunStepAsync) | |||
| await RunStepAsync(); | |||
There was a problem hiding this comment.
Note that the async continuation is probably executed from setTimer(... , 0) so, if there is work in that scheduler, it may impact measurement. But compared to whole emscripten startup, probably not big problem.
There was a problem hiding this comment.
Yeah. I think there should not be much else happening at that time, besides things which are part of the startup.
Not sure whether we can improve that.
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Measure browser app start times, 2 measurements implemented.
First to measure till the JS window.pageshow event, second to measure
time when we reach managed C# code.
Example ouput: