-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete dead code #61533
Merged
Merged
Delete dead code #61533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unused.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Nov 12, 2021
ghost
added
the
community-contribution
Indicates that the PR has been added by a community member
label
Nov 12, 2021
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsIncluding "unused" bits. Removal of No diffs are expected.
|
SingleAccretion
force-pushed
the
Delete-Dead-Code
branch
from
November 12, 2021 23:46
e6602a3
to
5557daa
Compare
Unused.
The conditions tested constitute invalid IR.
SingleAccretion
force-pushed
the
Delete-Dead-Code
branch
from
November 13, 2021 00:10
5557daa
to
392153a
Compare
Opened #61548 for the unrelated failure. @dotnet/jit-contrib |
Unused.
Unused.
SingleAccretion
force-pushed
the
Delete-Dead-Code
branch
from
November 13, 2021 19:41
6c938b6
to
8ab0092
Compare
Unused.
BruceForstall
approved these changes
Nov 15, 2021
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Dec 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
community-contribution
Indicates that the PR has been added by a community member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including "unused" bits.
Removal of
argRegList
saves0.33%
in memory consumption when CG-ing x86 CoreLib (with the native Jit).No diffs.