Add [Fact] attributes on TypeGeneratorTests #61534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now there's no functional change to the behavior of the tests, I have just copied the bits to inject from Jeremy's example in his pending PR. Thanks Tomas
|
Tagging subscribers to this area: @hoyosjs Issue DetailsFor now there's no functional change to the behavior of the tests, Thanks Tomas Contributes to: #54512
|
|
I have triggered a CoreCLR outerloop run but not the CI run as I believe all these tests are Pri1 so that they don't run in CI. |
jkoritzinsky
approved these changes
Nov 13, 2021
|
The arm / arm64 runs are pretty flaky these days but I have double-checked in the AzDO UI that none of the outstanding failures are related to the TypeGeneratorTests I'm modifying in this PR, merging in. |
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now there's no functional change to the behavior of the tests,
I have just copied the bits to inject from Jeremy's example in his
pending PR.
Thanks
Tomas
Contributes to: #54512