Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve System.Speech trimmability #61566

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Improve System.Speech trimmability #61566

merged 1 commit into from
Nov 15, 2021

Conversation

kant2002
Copy link
Contributor

by removing obvious warnings

@kant2002
Improve System.Speech trimmability
4a82333 
by removing obvious warnings
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 14, 2021
@ghost
Copy link

ghost commented Nov 14, 2021

Tagging subscribers to this area: @danmoseley
See info in area-owners.md if you want to be subscribed.

Issue Details

by removing obvious warnings

Author: kant2002
Assignees: -
Labels:

area-System.Speech
Milestone: -

@marek-safar marek-safar added the linkable-framework Issues associated with delivering a linker friendly framework label Nov 15, 2021
@ghost
Copy link

ghost commented Nov 15, 2021

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr
See info in area-owners.md if you want to be subscribed.

Issue Details

by removing obvious warnings

Author: kant2002
Assignees: -
Labels:

linkable-framework, area-System.Speech, community-contribution
Milestone: -

eerhardt
eerhardt reviewed Nov 15, 2021
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM.

Improve System.Speech trimmability

System.Speech isn't enabled for trimming at all today:

runtime/src/libraries/System.Speech/src/System.Speech.csproj

Line 8 in 4cf86c2

<SetIsTrimmable>false</SetIsTrimmable>

And we aren't baselining its trim warnings either:

runtime/src/libraries/illink-oob.targets

Line 25 in d0a0919

<_OOBsToIgnore Include="System.Speech" />

If we really want to make progress on Speech trimmability, we should probably be changing those places to enable trimming and start producing warnings for this library.

danmoseley
danmoseley approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup.

@danmoseley danmoseley merged commit 072e876 into dotnet:main Nov 15, 2021
@kant2002 kant2002 deleted the kant/speech-trimming branch November 20, 2021 14:25
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt left review comments

@danmoseley danmoseley danmoseley approved these changes

Assignees
No one assigned
Labels
area-System.Speech community-contribution Indicates that the PR has been added by a community member linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kant2002 @danmoseley @eerhardt @marek-safar