Commits on Nov 14, 2021

1. Delete impCheckForNullPointer …

   The comment above the method mentions "many problems" with leaving
   null pointers around, but it is unclear what kind of problems. I can
   only speculate those were the problems in legacy codegen which "could
   not handle constant op1".
   
   It also mentions that "we cannot even fold (null+offset)", which is
   incorrect: "gtFoldExprConst" does in fact fold such expressions to
   zero byrefs. It is also the case that spilling the null into a local
   affects little as local assertion propagation happily propagates the
   null back into its original place.
   
   There was also a little bug associated with the method that got fixed:
   morph was trying to use it, and in the process created uses of a local
   that was not initialized, since the statement list used by the method
   is the importer's one, invalid in morph.

   

   SingleAccretion committed Nov 14, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 4fa791f
   • Browse repository at this point

   Copy the full SHA

   4fa791f View commit details

   Browse the repository at this point in the history