JIT: Disable fgMorphCastedBitwiseOp opt for floats #61657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT |
SingleAccretion
approved these changes
Nov 16, 2021
jakobbotsch
approved these changes
Nov 16, 2021
kasperk81
reviewed
Nov 16, 2021
| Test(100, 200.0) + Test(Math.PI, Math.PI) - 72; | ||
|
|
||
| [MethodImpl(MethodImplOptions.NoInlining)] | ||
| static int Test(double a, double b) |
There was a problem hiding this comment.
does this fail on current main branch?
There was a problem hiding this comment.
In Checked builds where we have lots of asserts in JIT - yes. For Release one I am not sure
There was a problem hiding this comment.
I was seeing InvalidProgramException getting thrown for the pattern in the issue in release builds. So likely for this one too.
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61629