prevent concurrent access to IO buffers on macOS #61723
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, the read and write path is separate and since we do not allow parallel reads or parallel writes there was no need to worry about concurrent access.
However, calling
Dispose
while handshake is happening can clear the buffers and we would get the Assert (in debug builds).This change adds lock to prevent Dispose while in IO functions. (and vice versa)
We really only manipulate the buffers - there is no real IO under the lock.
I was not able to reproduce the Assert locally so this is based on code inspection.
I did ~ 100 runs (and running) and I did not see any side effects. e.g. all test are passing normally.
fixes #43686