Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mono] Enable some skipped Android tests #61771

Merged
merged 2 commits into from
Nov 22, 2021
Merged

[Mono] Enable some skipped Android tests #61771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
888694a
Revert "[Mono] Skip flaky android tests (#61460)"
simonrozsival Nov 18, 2021
250dfff
Merge branch 'main' of github.com:simonrozsival/runtime into simonroz…
simonrozsival Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/libraries/System.Net.Ping/tests/FunctionalTests/UnixPingUtilityTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ public class UnixPingUtilityTests
[InlineData(1000)]
[InlineData(1500)]
[PlatformSpecific(TestPlatforms.AnyUnix)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)]
public static void TimeoutIsRespected(int timeout)
{
Process p = ConstructPingProcess(IPAddress.Parse(TestSettings.UnreachableAddress), 50, timeout);
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/System.Net.Sockets/tests/FunctionalTests/SendTo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ public async Task NullEndpoint_Throws_ArgumentException()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)]
public async Task Datagram_UDP_ShouldImplicitlyBindLocalEndpoint()
{
using var socket = new Socket(AddressFamily.InterNetwork, SocketType.Dgram, ProtocolType.Udp);
Expand All @@ -85,7 +84,6 @@ public async Task Datagram_UDP_ShouldImplicitlyBindLocalEndpoint()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)]
public async Task Datagram_UDP_AccessDenied_Throws_DoesNotBind()
{
IPEndPoint invalidEndpoint = new IPEndPoint(IPAddress.Broadcast, 1234);
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ public void ReuseUnicastPort_CreateSocketSetOption()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)]
public void MulticastOption_CreateSocketSetGetOption_GroupAndInterfaceIndex_SetSucceeds_GetThrows()
{
int interfaceIndex = 0;
Expand All @@ -66,7 +65,6 @@ public void MulticastOption_CreateSocketSetGetOption_GroupAndInterfaceIndex_SetS
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoNorServerCore))] // Skip on Nano: https://github.com/dotnet/runtime/issues/26286
[ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)]
public async Task MulticastInterface_Set_AnyInterface_Succeeds()
{
// On all platforms, index 0 means "any interface"
Expand Down
4 changes: 0 additions & 4 deletions src/libraries/System.Net.Sockets/tests/FunctionalTests/UdpClientTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,6 @@ public void Connect_InvalidArguments_Throws()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)]
public async Task ConnectAsync_StringHost_Success()
{
using (var c = new UdpClient())
Expand All @@ -449,7 +448,6 @@ public async Task ConnectAsync_StringHost_Success()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)]
public async Task ConnectAsync_IPAddressHost_Success()
{
using (var c = new UdpClient())
Expand All @@ -459,7 +457,6 @@ public async Task ConnectAsync_IPAddressHost_Success()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)]
public void Connect_StringHost_Success()
{
using (var c = new UdpClient())
Expand All @@ -469,7 +466,6 @@ public void Connect_StringHost_Success()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61343", TestPlatforms.Android)]
public void Connect_IPAddressHost_Success()
{
using (var c = new UdpClient())
Expand Down