Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand Regex One/Notone/Setlazy simple code gen support to Lazy #61784

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Expand Regex One/Notone/Setlazy simple code gen support to Lazy #61784

merged 1 commit into from
Nov 19, 2021

Commits on Nov 19, 2021

  1. Expand One/Notone/Setlazy support to Lazy 

    The logic added in a recent PR to support simplified code generation for a Regex with {One/Notone/Set}lazy nodes is almost sufficient to support Lazy as well.  This fills the gap.  It also deletes an erroneous optimization added in .NET 5 that removed top-level Atomic nodes; the idea behind it was that such nodes are meaningless as, at the top-level, nothing can backtrack in anyway, but it then means that any node which is paying attention to whether its parent is Atomic may no longer find it (and that's needed by Lazy).
    @stephentoub
    stephentoub committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    854795b View commit details
    Browse the repository at this point in the history