[wasm] debug with modularized runtime(s) #61848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @thaystg Issue DetailsIt doesn't work yet
|
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsIt doesn't work yet
|
lewing
reviewed
Nov 19, 2021
pavelsavara
force-pushed
the
wasm_debug_multiple_runtimes
branch
2 times, most recently
from
4b82de2
to
f6b1a7a
Compare
pavelsavara
force-pushed
the
wasm_debug_multiple_runtimes
branch
from
eab63aa
to
a780dc9
Compare
pavelsavara
changed the title
kg
reviewed
Nov 24, 2021
pavelsavara
changed the title
thaystg
reviewed
Nov 24, 2021
thaystg
approved these changes
Nov 24, 2021
|
|
radical
reviewed
Nov 24, 2021
|
@lewing we would appreciate your feedback on this PR, proxy code in particular. If you have any comments I will fix it in future PRs. Will merge this now. |
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After we modularize the runtime, the APIs like
MONOorINTERNALwould not be on globalThis anymore.Also, there would be possibility to instantiate multiple runtimes in the same web page.
I don't think that multiple runtimes on same page nor multiple debuggers running on same page in parallel are very likely scenarios. This PR is just neat way how to allow that possibility in the future, while solving the isolation that ES6 will bring.
Changes
globalThis.getDotnetRuntimemethod, which takesruntimeId, essentially index of the runtime on the page. It returns theDotNetPublicAPIobject of the instance{MONO, BINDING, Module, RuntimeId, RuntimeBuildInfo }.getDotnetRuntime()in unit tests, with runtimeId is zero as there is only one runtime in tests.&runtimeId=0to the initial URL which opens DebuggerProxy, so that MonoProxy could be created for specific runtime on the page.mono_wasm_add_dbg_command_received,mono_wasm_debugger_logandmono_wasm_trace_loggerout of C macro into typescriptRuntimeBuildInfo: { ProductVersion, Configuration }intoDotNetPublicAPI