-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TODO-List-Cleanup] Delete dead code from InferStructOpSizeAlign
#61880
[TODO-List-Cleanup] Delete dead code from InferStructOpSizeAlign
#61880
Conversation
The method's only caller is InferOpSizeAlign. That is in turn only used in LCL_FLD stress, which only looks at locals with non-struct types. And "fgInitArgInfo", which only allows 3 nodes with TYP_STRUCT: OBJ, LCL_VAR and MKREFANY. Thus, this code is dead. Not surprising, considering it was looking for the old GT_COPYBLK representation.
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThe method's only caller is That is in turn only used in And Thus, this code is dead. Not surprising, considering it was looking for the old
|
InferStructOpSizeAlign
InferStructOpSizeAlign
@dotnet/jit-contrib |
@BruceForstall PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution!
The method's only caller is
InferOpSizeAlign
.That is in turn only used in
LCL_FLD
stress, which only looks at locals with non-struct types.And
fgInitArgInfo
, which only allows 3 nodes withTYP_STRUCT
:OBJ
,LCL_VAR
andMKREFANY
.Thus, this code is dead. Not surprising, considering it was looking for the old
GT_COPYBLK
representation.No diffs.