Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO-List-Cleanup] Delete dead code from InferStructOpSizeAlign #61880

Merged

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Nov 20, 2021

The method's only caller is InferOpSizeAlign.

That is in turn only used in LCL_FLD stress, which only looks at locals with non-struct types.

And fgInitArgInfo, which only allows 3 nodes with TYP_STRUCT: OBJ, LCL_VAR and MKREFANY.

Thus, this code is dead. Not surprising, considering it was looking for the old GT_COPYBLK representation.

No diffs.

The method's only caller is InferOpSizeAlign.

That is in turn only used in LCL_FLD stress, which
only looks at locals with non-struct types.

And "fgInitArgInfo", which only allows 3 nodes with
TYP_STRUCT: OBJ, LCL_VAR and MKREFANY.

Thus, this code is dead. Not surprising, considering
it was looking for the old GT_COPYBLK representation.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 20, 2021
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 20, 2021
@ghost
Copy link

ghost commented Nov 20, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

The method's only caller is InferOpSizeAlign.

That is in turn only used in LCL_FLD stress, which only looks at locals with non-struct types.

And fgInitArgInfo, which only allows 3 nodes with TYP_STRUCT: OBJ, LCL_VAR and MKREFANY.

Thus, this code is dead. Not surprising, considering it was looking for the old GT_COPYBLK representation.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@SingleAccretion SingleAccretion changed the title Delete dead code from InferStructOpSizeAlign [TODO-List-Cleanup] Delete dead code from InferStructOpSizeAlign Nov 20, 2021
@SingleAccretion SingleAccretion marked this pull request as ready for review November 20, 2021 21:18
@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib

@JulieLeeMSFT
Copy link
Member

@BruceForstall PTAL.

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants